Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from using docvalue_fields to extracting values from _source #44062

Merged
merged 13 commits into from
Jul 24, 2019
Merged

Switch from using docvalue_fields to extracting values from _source #44062

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4f2aba6
Switch from using docvalue_fields to extracting values from _source
astefan Jun 12, 2019
3734353
Fix tests
astefan Jul 8, 2019
36ea8be
More tests updates
astefan Jul 8, 2019
2e5ace8
Addressing review and adding more tests
astefan Jul 15, 2019
21c930a
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Jul 17, 2019
a9bf6bc
Limitations page update
astefan Jul 17, 2019
f750eaf
Adressing reviews
astefan Jul 18, 2019
f6e0cf3
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Jul 18, 2019
3977431
Add backwards compatibility checks for newly added serialized info
astefan Jul 22, 2019
142dd6b
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Jul 22, 2019
f9bb0d2
Small updates
astefan Jul 24, 2019
01cd9ec
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
astefan Jul 24, 2019
c1eaf79
Fix test
astefan Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions docs/reference/sql/limitations.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ Therefore calling `ST_Z` function in the filtering, grouping or sorting will ret
[[fields-from-source]]
=== Retrieving from _source

Most of {es-sql}'s columns are retrieved from `_source`, even though the mapping may disable the <<mapping-source-field,`_source`>> field.
If such a column is explicitly asked for in a query, {es-sql} will not return it. Field types NOT returned from `_source` include: `keyword`,
`date`, `scaled_float`, `geo_point`, `geo_shape`.
Most of {es-sql}'s columns are retrieved from the document's `_source` and there is no attempt to get the columns content from
`docvalue_fields` not even in the case <<mapping-source-field,`_source`>> field is disabled in the mapping explicitly.
If a column, for which there is no source stored, is asked for in a query, {es-sql} will not return it. Field types NOT returned
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe: Field types that don't follow this restriction are: .... since they are NOT returned from _source but from doc values.

from `_source` are: `keyword`, `date`, `scaled_float`, `geo_point`, `geo_shape`.