Fix incorrect calculation of how many buckets will result from a merge #44461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo |
pcsanwald
commented
Jul 16, 2019
|
|
||
| @Override | ||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/39497") | ||
| // TODO: When resolving the above AwaitsFix, just delete this override. Method is only overriden to apply the annotation. |
There was a problem hiding this comment.
I've unmuted this test because the bug could have caused some of the failures we've seen previously, which seem to be off by one errors, such as in #39497. Some of those failures look quite similar:
> Throwable #1: java.lang.AssertionError: expected:<{1548979200000=989}> but was:<{1548979200000=928, 1551398400000=61}>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #43577
Reproducing the problem in the issue showed that this calculation is incorrect:
because we can end up with extra buckets if the remainder here is not zero.