Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML-DataFrame] fix test failure in checkpoint retrieval #45297

Merged
merged 4 commits into from
Aug 9, 2019
Merged

[ML-DataFrame] fix test failure in checkpoint retrieval #45297

merged 4 commits into from
Aug 9, 2019

Conversation

hendrikmuhs
Copy link

@hendrikmuhs hendrikmuhs commented Aug 7, 2019 •
edited
Loading

gracefully handle if index response returns null, increase and assert timeout

closes #45238

@hendrikmuhs hendrikmuhs added WIP >test-failure Triaged test failures from CI :ml/Transform Transform labels Aug 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

3 similar comments
@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs hendrikmuhs marked this pull request as ready for review August 8, 2019 08:54
@hendrikmuhs hendrikmuhs changed the title [ML-DataFrame] investigate checkpoint retrieval problem [ML-DataFrame] fix test failure in checkpoint retrieval Aug 8, 2019
@hendrikmuhs hendrikmuhs added the WIP label Aug 8, 2019
@hendrikmuhs
Copy link
Author

Back to work in progress, the issue happened again, unfortunately now that I put the loglevels back to debug.

@hendrikmuhs hendrikmuhs removed the WIP label Aug 8, 2019
przemekwitek
przemekwitek approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs hendrikmuhs merged commit 151724f into elastic:master Aug 9, 2019
hendrikmuhs pushed a commit that referenced this pull request Aug 9, 2019
[ML-DataFrame] fix test failure in checkpoint retrieval (#45297)
7d0aff0 
gracefully handle if index response returns null, increase and assert timeout

closes #45238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemekwitek przemekwitek przemekwitek approved these changes

Assignees
No one assigned
Labels
:ml/Transform Transform >test-failure Triaged test failures from CI v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
4 participants
@hendrikmuhs @elasticmachine @przemekwitek @jakelandis