Fix testIndexhasDuplicateData tests #49786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testIndexHasDuplicateData tests were failing ocassionally, due to approximate calculation of BKDReader.estimatePointCount, where if the node is Leaf, the number of points in it was (maxPointsInLeafNode + 1) / 2. As DEFAULT_MAX_POINTS_IN_LEAF_NODE = 1024, for small indexes used in tests, the estimation could be really off. This rewrites tests, to make the max points in leaf node to be a small value to control the tests. Closes elastic#49703
mayya-sharipova
added
the
:Search/Search
|
Pinging @elastic/es-search (:Search/Search) |
mayya-sharipova
added
>test-failure
jimczi
approved these changes
Mar 19, 2020
mayya-sharipova
added a commit
that referenced
this pull request
Mar 19, 2020
testIndexHasDuplicateData tests were failing ocassionally, due to approximate calculation of BKDReader.estimatePointCount, where if the node is Leaf, the number of points in it was (maxPointsInLeafNode + 1) / 2. As DEFAULT_MAX_POINTS_IN_LEAF_NODE = 1024, for small indexes used in tests, the estimation could be really off. This rewrites tests, to make the max points in leaf node to be a small value to control the tests. Closes #49703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testIndexHasDuplicateData tests were failing ocassionally,
due to approximate calculation of BKDReader.estimatePointCount,
where if the node is Leaf, the number of points in it
was (maxPointsInLeafNode + 1) / 2.
As DEFAULT_MAX_POINTS_IN_LEAF_NODE = 1024, for small indexes
used in tests, the estimation could be really off.
This rewrites tests, to make the max points in leaf node to
be a small value to control the tests.
Closes #49703