-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow symlinks in Docker entrypoint #50927
Follow symlinks in Docker entrypoint #50927
Conversation
Closes elastic#49653. When using _FILE environment variables to supply values to Elasticsearch, following symlinks when checking that file permissions are secure.
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The improvements in 954d3f5 are really good IMO and should help troubleshooting and the general user experience with this feature.
@elasticmachine update branch |
Closes elastic#49653. When using _FILE environment variables to supply values to Elasticsearch, following symlinks when checking that file permissions are secure.
Closes elastic#49653. When using _FILE environment variables to supply values to Elasticsearch, following symlinks when checking that file permissions are secure.
Closes elastic#49653. When using _FILE environment variables to supply values to Elasticsearch, following symlinks when checking that file permissions are secure.
Closes #49653. When using _FILE environment variables to supply values to Elasticsearch, following symlinks when checking that file permissions are secure.
The pertinent change is adding
-L
to thestat
call inelasticsearch-env-from-file
.