Add ComponentTemplate to MetaData #53290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `ComponentTemplate` datastructure that will be used as part of elastic#53101 (Index Templates v2) to the `MetaData` class. Currently there are no APIs for interacting with this class, so it will always be an empty map (other than in tests). This infrastructure will be built upon to add APIs in a subsequent commit. A `ComponentTemplate` is made up of a `Template`, a version, and an arbitrary metadata map. The `Template` contains similar information to an `IndexTemplateMetaData` object— settings, mappings, and alias configuration.
dakrone
added
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
|
This PR does not yet contain the APIs for put/get/deleting the component templates, however, it is already large enough and I wanted to split the work up to make it easier to review. I plan on working on the APIs immediately after this. |
probakowski
approved these changes
Mar 9, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java
Show resolved
Hide resolved
| Map<String, Object> uncompressedMapping = | ||
| XContentHelper.convertToMap(new BytesArray(this.mappings.uncompressed()), true, XContentType.JSON).v2(); | ||
| if (uncompressedMapping.size() > 0) { | ||
| builder.field(MAPPINGS.getPreferredName()); |
There was a problem hiding this comment.
If we have empty settings or mappings section we still have corresponding field but we skip it in case of mappings, any reason for that?
There was a problem hiding this comment.
No specific reason, this was copied to mimic the existing behavior of for index templates
martijnvg
reviewed
Mar 10, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetaData.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/ComponentTemplate.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
martijnvg
approved these changes
Mar 12, 2020
server/src/main/java/org/elasticsearch/cluster/DiffableUtils.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 12, 2020
* Add ComponentTemplate to MetaData This adds a `ComponentTemplate` datastructure that will be used as part of elastic#53101 (Index Templates v2) to the `MetaData` class. Currently there are no APIs for interacting with this class, so it will always be an empty map (other than in tests). This infrastructure will be built upon to add APIs in a subsequent commit. A `ComponentTemplate` is made up of a `Template`, a version, and a MetaData.Custom class. The `Template` contains similar information to an `IndexTemplateMetaData` object— settings, mappings, and alias configuration.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 12, 2020
This disables the BWC tests for the ComponentTemplateMetadata class added in elastic#53290 and elastic#53489
dakrone
added a commit
that referenced
this pull request
Mar 12, 2020
dakrone
added a commit
that referenced
this pull request
Mar 12, 2020
* Add ComponentTemplate to MetaData (#53290) * Add ComponentTemplate to MetaData This adds a `ComponentTemplate` datastructure that will be used as part of #53101 (Index Templates v2) to the `MetaData` class. Currently there are no APIs for interacting with this class, so it will always be an empty map (other than in tests). This infrastructure will be built upon to add APIs in a subsequent commit. A `ComponentTemplate` is made up of a `Template`, a version, and a MetaData.Custom class. The `Template` contains similar information to an `IndexTemplateMetaData` object— settings, mappings, and alias configuration. * Update minimal supported version constant Co-authored-by: Elastic Machine <[email protected]>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
ComponentTemplatedatastructure that will be used as part of #53101 (Index Templatesv2) to the
MetaDataclass. Currently there are no APIs for interacting with this class, so it willalways be an empty map (other than in tests). This infrastructure will be built upon to add APIs in
a subsequent commit.
A
ComponentTemplateis made up of aTemplate, a version, and an arbitrary metadata map. TheTemplatecontains similar information to anIndexTemplateMetaDataobject— settings, mappings,and alias configuration.