Use QueryVisitor when extracting PercolatorQuery list for highlighting #53728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Relevance/Percolator
|
Pinging @elastic/es-search (:Search/Percolator) |
romseygeek
added a commit
that referenced
this pull request
Mar 18, 2020
#53728) The highlighting phase for percolator queries currently uses some custom query traversal logic to find all instances of PercolatorQuery in the query tree for the current search context. This commit converts things to instead use a QueryVisitor, which future-proofs us against new wrapper queries or queries from custom plugins that the percolator module doesn't know about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlighting phase for percolator queries currently uses some custom query
traversal logic to find all instances of
PercolatorQueryin the query tree for thecurrent search context. This commit converts things to instead use a
QueryVisitor,which future-proofs us against new wrapper queries or queries from custom
plugins that the percolator module doesn't know about.