Transition Transforms to using hidden indices for notifcations index #53773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the Transforms notifications index to be hidden index, with a hidden alias. This commit also removes the temporary hack in MetaDataCreateIndexService that prevents deprecation warnings for known dot-prefixed index names which are not hidden/system indices, as this was the last index pattern to need that hack.
|
Pinging @elastic/ml-core (:ml/Transform) |
|
@elasticmachine update branch |
|
Something appears to have happened in master recently and deprecation warnings seem to no longer being emitted over the REST interface when indices are created with dot-prefixed names (despite the unit tests for the deprecation warnings still working), and the test that failed did so because the deprecation warning it expected is not emitted. Going to hold off on merging this until I figure out what's going on there. |
|
Per some discussion in Slack, looks like the change in behavior is related to #53785. |
|
@elasticmachine update branch |
|
Thanks @DaveCTurner, much appreciated! No worries, stuff happens. Just wanted to make sure I didn't have to make some other adjustment. |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 20, 2020
…lastic#53773) This commit changes the Transforms notifications index to be hidden index, with a hidden alias. This commit also removes the temporary hack in MetaDataCreateIndexService that prevents deprecation warnings for known dot-prefixed index names which are not hidden/system indices, as this was the last index pattern to need that hack.
gwbrown
added a commit
that referenced
this pull request
Mar 20, 2020
…53773) This commit changes the Transforms notifications index to be hidden index, with a hidden alias. This commit also removes the temporary hack in MetaDataCreateIndexService that prevents deprecation warnings for known dot-prefixed index names which are not hidden/system indices, as this was the last index pattern to need that hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Transforms notifications index to be hidden
index, with a hidden alias.
This commit also removes the temporary hack in
MetaDataCreateIndexService that prevents deprecation warnings for known
dot-prefixed index names which are not hidden/system indices, as this
was the last index pattern to need that hack.
/cc @jaymode
Fixes #53762