Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check authentication type using enum instead of string #54145

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Check authentication type using enum instead of string #54145

merged 1 commit into from
Mar 26, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Mar 25, 2020

This refactor is a follow up for #52178.

Resolves: #52511

@ywangd ywangd added >enhancement :Security/Security Security issues without another label v8.0.0 v7.7.0 labels Mar 25, 2020
@ywangd ywangd requested a review from albertzaharovits March 25, 2020 03:10
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Security)

@bpintea bpintea added v7.8.0 and removed v7.7.0 labels Mar 25, 2020
albertzaharovits
albertzaharovits approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you Yang for tackling this!

@ywangd ywangd merged commit e244a3b into elastic:master Mar 26, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Mar 26, 2020
@ywangd
Check authentication type using enum instead of string (elastic#54145)
14855b7 
Avoid string comparison when we can use safter enums.
This refactor is a follow up for elastic#52178.

Resolves: elastic#52511
ywangd added a commit that referenced this pull request Mar 26, 2020
@ywangd
Check authentication type using enum instead of string (#54145) (#54246)
1afd510 
Avoid string comparison when we can use safer enums.
This refactor is a follow up for #52178.

Resolves: #52511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees
No one assigned
Labels
>refactoring :Security/Security Security issues without another label v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor API key creator realm check
6 participants
@ywangd @elasticmachine @albertzaharovits @jakelandis @bpintea @pugnascotia