Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error_trace parameter to REST test helper #54259

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add error_trace parameter to REST test helper #54259

merged 1 commit into from
Mar 26, 2020

Conversation

DaveCTurner
Copy link
Contributor

Today the XPackRestTestHelper makes some REST calls without the error_trace
parameter, so that if they fail due to an exception we do not see very much
detail. This commit adds the error_trace parameter to help identify why these
REST calls fail.

@DaveCTurner
Add error_trace parameter to REST test helper
6c9d681 
Today the `XPackRestTestHelper` makes some REST calls without the `error_trace`
parameter, so that if they fail due to an exception we do not see very much
detail. This commit adds the `error_trace` parameter to help identify why these
REST calls fail.
@DaveCTurner DaveCTurner added the :Core/Infra/REST API REST infrastructure and utilities label Mar 26, 2020
@DaveCTurner DaveCTurner requested a review from davidkyle March 26, 2020 11:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests v7.7.1 v7.8.0 v8.0.0 labels Mar 26, 2020
@DaveCTurner
Copy link
Contributor Author

Relates https://gradle-enterprise.elastic.co/s/lzgws4z5monlm:

org.elasticsearch.client.ResponseException: method [GET], host [http://[::1]:53715], URI [/_cat/nodes?h=master%2Cversion], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"Values less than -1 bytes are not supported: -44383772672b"}],"type":"illegal_argument_exception","reason":"Values less than -1 bytes are not supported: -44383772672b"},"status":400}
	at __randomizedtesting.SeedInfo.seed([4E3062DA63B01BD3:4A516CAB0875ACBE]:0)
	at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:283)
	at org.elasticsearch.client.RestClient.performRequest(RestClient.java:261)
	at org.elasticsearch.client.RestClient.performRequest(RestClient.java:235)
	at org.elasticsearch.xpack.test.rest.XPackRestTestHelper.lambda$waitForTemplates$0(XPackRestTestHelper.java:47)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:905)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:890)
	at org.elasticsearch.xpack.test.rest.XPackRestTestHelper.waitForTemplates(XPackRestTestHelper.java:44)
	at org.elasticsearch.xpack.restart.MlConfigIndexMappingsFullClusterRestartIT.waitForMlTemplates(MlConfigIndexMappingsFullClusterRestartIT.java:62)

I do not think this failure is related to the test, I think there's something more fundamental going wrong, but without a stack trace it seems hopeless to investigate further.

davidkyle
davidkyle approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

You can always grab the server logs by clicking the 'GCP Upload' link from the gradle scan. I grabbed the xpack full cluster restart logs for you

full-cluster-restart.zip

@davidkyle
Copy link
Member

Oh i see the error isn't in the logs, you probably checked that already. Sorry

@DaveCTurner
Copy link
Contributor Author

https://gradle-enterprise.elastic.co/s/7w75tddsv5rss is another one of these.

I actually hadn't checked the server logs, thanks. I am not surprised that they didn't contain anything useful.

@DaveCTurner DaveCTurner merged commit ece0ca1 into elastic:master Mar 26, 2020
@DaveCTurner DaveCTurner deleted the 2020-03-26-error-trace-in-rest-test-helper branch March 26, 2020 14:03
DaveCTurner added a commit that referenced this pull request Mar 26, 2020
@DaveCTurner
Add error_trace parameter to REST test helper (#54259)
ffe1ba3 
Today the `XPackRestTestHelper` makes some REST calls without the `error_trace`
parameter, so that if they fail due to an exception we do not see very much
detail. This commit adds the `error_trace` parameter to help identify why these
REST calls fail.
DaveCTurner added a commit that referenced this pull request Mar 26, 2020
@DaveCTurner
Add error_trace parameter to REST test helper (#54259)
20e821e 
Today the `XPackRestTestHelper` makes some REST calls without the `error_trace`
parameter, so that if they fail due to an exception we do not see very much
detail. This commit adds the `error_trace` parameter to help identify why these
REST calls fail.
@benwtrent
Copy link
Member

benwtrent commented Mar 30, 2020 •
edited
Loading

Here is another failure : https://gradle-enterprise.elastic.co/s/or7qqkbuuazto

Both the 7.x code and the 7.7.0 code contain your commit. Hopefully the additional logs help.

@benwtrent benwtrent mentioned this pull request Mar 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >test Issues or PRs that are addressing/adding tests v7.7.1 v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DaveCTurner @elasticmachine @davidkyle @benwtrent @jakelandis