Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename examples in ILM guide to avoid association with data streams #54502

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

danhermann
Copy link
Contributor

The examples in the ILM guide use "datastream" as the base name for templates, policies, etc. With the introduction of the data streams primitive in ES, I could see this confusing users into thinking that ILM and data streams are synonyms or necessarily related or something similar. I suggest changing the naming in the examples to something else to avoid that potential confusion. I used "timeseries" here but other names could work, too.

@danhermann danhermann added the >docs General docs changes label Mar 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad you found this prior to datastreams being released, that would have been confusing.

@danhermann danhermann merged commit 365d7b3 into elastic:master Apr 1, 2020
@danhermann danhermann deleted the rename_ilm_examples branch April 1, 2020 13:29
@danhermann danhermann added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants