Add get autoscaling policy API #54762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the get autoscaling policy API.
|
Pinging @elastic/es-distributed (:Distributed/Autoscaling) |
henningandersen
approved these changes
Apr 4, 2020
|
|
||
| [source,console-result] | ||
| -------------------------------------------------- | ||
| { |
There was a problem hiding this comment.
I wonder if we need an array to prepare for listing all deciders? I guess we can state we will never add wildcard support and hence it is two different endpoints, i.e., this is OK?
There was a problem hiding this comment.
Yeah, I do not think that we should support wildcards, or getting multiple policies at once (comma-separated). In general, I think that it greatly complicates our APIs (e.g., what do we do if one policy exists, and another doesn't? we have faced these challenges with existing APIs and I think it's just complicated our APIs and their implementations with little benefit to our users).
jasontedor
added a commit
that referenced
this pull request
Apr 4, 2020
This commit adds the get autoscaling policy API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the get autoscaling policy API.