[ML] adding prediction_field_type to inference config #55128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (:ml) |
|
@elasticmachine update branch |
...src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictedFieldType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictedFieldType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictedFieldType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictedFieldType.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictedFieldType.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/ClassificationConfig.java
Outdated
Show resolved
Hide resolved
.../ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/process/AnalyticsResultProcessor.java
Outdated
Show resolved
Hide resolved
…' of github.com:benwtrent/elasticsearch into feature/ml-inference-handle-different-target-field-typs
lcawl
reviewed
Apr 14, 2020
| @@ -382,6 +382,10 @@ include::{docdir}/ml/ml-shared.asciidoc[tag=inference-config-results-field] | |||
| `top_classes_results_field`:::: | |||
| (Optional, string) | |||
| include::{docdir}/ml/ml-shared.asciidoc[tag=inference-config-classification-top-classes-results-field] | |||
|
|
|||
| `prediction_field_type`:::: | |||
There was a problem hiding this comment.
prediction_field_type
Not a big deal, but these properties are typically sorted alphabetically, and this seems to fall out of that sort order.
przemekwitek
approved these changes
Apr 15, 2020
| throw new IllegalArgumentException( | ||
| "Cannot transform numbers other than 0.0 or 1.0 to boolean. Provided number [" + value + "]"); | ||
| } | ||
| return (1.0D - value) <= EPS; |
There was a problem hiding this comment.
Could areClose be used here as well for clarity?
| import java.util.Locale; | ||
|
|
||
| /** | ||
| * The type of the predicted field. |
There was a problem hiding this comment.
s/predicted/prediction/
?
|
@elasticmachine update branch |
benwtrent
deleted the
feature/ml-inference-handle-different-target-field-typs
branch
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 15, 2020
Data frame analytics dynamically determines the classification field type. This field type then dictates the encoded JSON that is written to Elasticsearch. Inference needs to know about this field type so that it may provide the EXACT SAME predicted values as analytics. Here is added a new field `prediction_field_type` which indicates the desired type. Options are: `string` (DEFAULT), `number`, `boolean` (where close_to(1.0) == true, false otherwise). Analytics provides the default `prediction_field_type` when the model is created from the process.
benwtrent
added a commit
that referenced
this pull request
Apr 15, 2020
…55230) * [ML] adding prediction_field_type to inference config (#55128) Data frame analytics dynamically determines the classification field type. This field type then dictates the encoded JSON that is written to Elasticsearch. Inference needs to know about this field type so that it may provide the EXACT SAME predicted values as analytics. Here is added a new field `prediction_field_type` which indicates the desired type. Options are: `string` (DEFAULT), `number`, `boolean` (where close_to(1.0) == true, false otherwise). Analytics provides the default `prediction_field_type` when the model is created from the process.
17 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data frame analytics dynamically determines the classification field type. This field type then dictates the encoded JSON that is written to Elasticsearch.
Inference needs to know about this field type so that it may provide the EXACT SAME predicted values as analytics.
Here is added a new field
prediction_field_typewhich indicates the desired type. Options are:string(DEFAULT),number,boolean(where close_to(1.0) == true, false otherwise).Analytics provides the default
prediction_field_typewhen the model is created from the process.