Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit deprecation warning if multiple v1 templates match with a new index #55558

Merged
merged 14 commits into from
Apr 30, 2020
Merged

Emit deprecation warning if multiple v1 templates match with a new index #55558

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
28ec770
Emit deprecation warning if multiple v1 templates match with a new index
probakowski Apr 21, 2020
6743582
fix test
probakowski Apr 22, 2020
41beebc
Update server/src/main/java/org/elasticsearch/cluster/metadata/Metada…
probakowski Apr 22, 2020
8ef9006
fix test
probakowski Apr 22, 2020
bda8e7a
run tests
probakowski Apr 27, 2020
4f3ace6
Merge branch 'master' into deprecate-multiple-v1-templates
elasticmachine Apr 27, 2020
98416cf
fix tests
probakowski Apr 28, 2020
05219f5
fix tests
probakowski Apr 28, 2020
6593967
fix tests
probakowski Apr 28, 2020
ec5b2b9
Merge branch 'master' into deprecate-multiple-v1-templates
elasticmachine Apr 28, 2020
96ad012
fix tests
probakowski Apr 28, 2020
5c03792
fix tests
probakowski Apr 29, 2020
e648e43
message change
probakowski Apr 29, 2020
4613851
Merge branch 'master' into deprecate-multiple-v1-templates
elasticmachine Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,12 @@ public ClusterState applyCreateIndexRequest(ClusterState currentState, CreateInd
final List<IndexTemplateMetadata> v1Templates = MetadataIndexTemplateService.findV1Templates(currentState.metadata(),
request.index(), isHiddenFromRequest);

if (v1Templates.size() > 1) {
deprecationLogger.deprecatedAndMaybeLog("index_template_multiple_match", "index [{}] matches multiple templates " +
"[{}], it won't be supported with index templates v2", request.index(),
probakowski marked this conversation as resolved.
Show resolved Hide resolved
v1Templates.stream().map(IndexTemplateMetadata::name).collect(Collectors.joining(", ")));
}

return applyCreateIndexRequestWithV1Templates(currentState, request, silent, v1Templates, metadataTransformer);
}
}
Expand Down