-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for V2 index templates to /_cat/templates #55829
Merged
dakrone
merged 3 commits into
elastic:master
from
dakrone:itv2-add-cat-template-support
Apr 28, 2020
Merged
Add support for V2 index templates to /_cat/templates #55829
dakrone
merged 3 commits into
elastic:master
from
dakrone:itv2-add-cat-template-support
Apr 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for V2 index templates to the cat templates API. It uses the `order` field as priority in order not to break compatibility, while adding the `composed_of` field to show component templates that are used from an index template. Relates to elastic#53101
Pinging @elastic/es-core-features (:Core/Features/CAT APIs) |
probakowski
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks @dakrone !
andreidan
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks Lee
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Apr 28, 2020
This adds support for V2 index templates to the cat templates API. It uses the `order` field as priority in order not to break compatibility, while adding the `composed_of` field to show component templates that are used from an index template. Relates to elastic#53101
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Apr 28, 2020
Now that elastic#55829 has been backported (elastic#55866) we can adjust these skip versions to allow testing with 7.8+. Relates to elastic#53101
dakrone
added a commit
that referenced
this pull request
Apr 28, 2020
dakrone
added a commit
that referenced
this pull request
Apr 28, 2020
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for V2 index templates to the cat templates API. It uses the
order
field aspriority in order not to break compatibility, while adding the
composed_of
field to show componenttemplates that are used from an index template.
Relates to #53101