Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geo_shape support for geotile_grid and geohash_grid #55966

Merged
merged 11 commits into from
May 5, 2020

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Apr 29, 2020

this commit adds aggregation support for the geo_shape field
type on geo*_grid aggregations.

it introduces a Tiler for both tiles and hashes that enables a new type of
ValuesSource to replace the GeoPoint's CellIdSource. This makes it possible
for the existing Aggregator to be re-used, so no new implementations of
the grid aggregators are added.

this commit adds aggregation support for the geo_shape field
type on geo*_grid aggregations.
@talevy talevy added >feature :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.8.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 29, 2020
@talevy talevy requested review from nknize and iverase April 29, 2020 19:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking good to me. Still we are lacking of protection for tiling a big shape with very small precision we can easily lead to OOM. I spoke with @talevy offline and we are going to try to address it before pushing.

Copy link
Contributor

@iverase iverase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@talevy talevy merged commit f26ee12 into elastic:master May 5, 2020
@talevy talevy deleted the ggrid branch May 5, 2020 15:00
talevy added a commit that referenced this pull request May 5, 2020
)

this commit adds aggregation support for the geo_shape field
type on geo*_grid aggregations.

it introduces a Tiler for both tiles and hashes that enables a new type of
ValuesSource to replace the GeoPoint's CellIdSource. This makes it possible
for the existing Aggregator to be re-used, so no new implementations of
the grid aggregators are added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >feature release highlight Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.8.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants