Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate non-negative priorities for V2 index templates #56139

Merged
merged 1 commit into from
May 4, 2020
Merged

Validate non-negative priorities for V2 index templates #56139

merged 1 commit into from
May 4, 2020

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented May 4, 2020

This also fixes an issue where a null priority was treated as below a 0 priority. null is now
treated as 0 priority when it comes to comparing V2 templates.

Relates to #53101

@dakrone
Validate non-negative priorities for V2 index templates
177af69 
This also fixes an issue where a `null` priority was treated as below a 0 priority. `null` is now
treated as 0 priority when it comes to comparing V2 templates.

Relates to elastic#53101
@dakrone dakrone added :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.8.0 labels May 4, 2020
@dakrone dakrone requested review from andreidan and probakowski May 4, 2020 18:18
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 4, 2020
@martijnvg martijnvg mentioned this pull request May 4, 2020
Closed
39 tasks
probakowski
probakowski approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dakrone dakrone merged commit cd6a892 into elastic:master May 4, 2020
@dakrone dakrone deleted the itv2-handle-negative-priorities branch May 4, 2020 20:46
@dakrone dakrone mentioned this pull request May 4, 2020
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this pull request May 4, 2020
@dakrone
Validate non-negative priorities for V2 index templates (elastic#56139)
a99dcc1 
This also fixes an issue where a `null` priority was treated as below a 0 priority. `null` is now
treated as 0 priority when it comes to comparing V2 templates.

Relates to elastic#53101
dakrone added a commit that referenced this pull request May 4, 2020
@dakrone
[7.x] Validate non-negative priorities for V2 index templates (#56139) (
8fa14b3 
#56163)

Backports the following commits to 7.x:
 - Validate non-negative priorities for V2 index templates (#56139)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probakowski probakowski probakowski approved these changes

@andreidan andreidan Awaiting requested review from andreidan

Assignees
No one assigned
Labels
>bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dakrone @elasticmachine @probakowski @jakelandis @pugnascotia