Don't allow invalid template combinations #56397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the ability to put V2 index templates that refence missing component templates. It also prevents removing component templates that are being referenced by an existing V2 index template. Relates to elastic#53101 Resolves elastic#56314
dakrone
added
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
Looks like CI ran out of memory: @elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
andreidan
approved these changes
May 14, 2020
andreidan
reviewed
May 14, 2020
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataIndexTemplateService.java
Outdated
Show resolved
Hide resolved
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
May 14, 2020
This commit removes the ability to put V2 index templates that reference missing component templates. It also prevents removing component templates that are being referenced by an existing V2 index template. Relates to elastic#53101 Resolves elastic#56314
dakrone
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the ability to put V2 index templates that reference missing component templates.
It also prevents removing component templates that are being referenced by an existing V2 index
template.
Relates to #53101
Resolves #56314