Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Component template APIs as experimental #57910

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Mark Component template APIs as experimental #57910

merged 2 commits into from
Jun 10, 2020

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jun 10, 2020

This commit marks the Component template APIs as experimental.

@russcam
Mark Component template APIs as experimental
c744c89 
This commit marks the Component template APIs as
experimental.
@russcam russcam added :Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team labels Jun 10, 2020
@russcam russcam requested a review from dakrone June 10, 2020 03:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 10, 2020
@russcam russcam mentioned this pull request Jun 10, 2020
Closed
@dakrone
Copy link
Member

dakrone commented Jun 10, 2020

I think this is missing the simulate APIs? indices.simulate_template and indices.simulate_index_template

@russcam
Copy link
Contributor Author

russcam commented Jun 10, 2020

I think this is missing the simulate APIs? indices.simulate_template and indices.simulate_index_template

I didn't know if these also needed to be marked experimental. I can update this PR for these. This PR will need to be ported to 7.x and 7.8 I think too, as indices.simulate_index_template is marked stable in 7.8:

elasticsearch/rest-api-spec/src/main/resources/rest-api-spec/api/indices.simulate_index_template.json

Line 7 in 202a15e

"stability":"stable",

@russcam
Copy link
Contributor Author

russcam commented Jun 10, 2020

@dakrone should it include all the indices.*_index_template APIs?

@dakrone
Copy link
Member

dakrone commented Jun 10, 2020

@dakrone should it include all the indices.*_index_template APIs?

Yep.

dakrone
dakrone approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russcam russcam merged commit a85f2be into elastic:master Jun 10, 2020
russcam added a commit that referenced this pull request Jun 10, 2020
@russcam
Mark Component and Index template APIs as experimental (#57910)
f51f9b1 
This commit marks the Component Template and
Index Template APIs as experimental.

(cherry picked from commit a85f2be)
russcam added a commit that referenced this pull request Jun 10, 2020
@russcam
Mark Component and Index template APIs as experimental (#57910)
88dbdef 
This commit marks the Component Template and
Index Template APIs as experimental.

(cherry picked from commit a85f2be)
@russcam russcam deleted the rest-specs/experimental-component-template branch June 10, 2020 04:10
@russcam
Copy link
Contributor Author

russcam commented Jun 10, 2020

ported to 7.x and 7.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@russcam @elasticmachine @dakrone