Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Hit counts and Miss counts for QueryCache exposed through REST api. This resolves:#48645 #60114

Merged
merged 3 commits into from
Jul 30, 2020
Merged

Adding Hit counts and Miss counts for QueryCache exposed through REST api. This resolves:#48645 #60114

merged 3 commits into from
Jul 30, 2020

Conversation

Raj-Datta-Manohar
Copy link
Contributor

@Raj-Datta-Manohar Raj-Datta-Manohar commented Jul 23, 2020 •
edited
Loading

Resolves #48645

@romseygeek romseygeek added the :Data Management/CAT APIs Text APIs behind /_cat label Jul 23, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 23, 2020
@Raj-Datta-Manohar Raj-Datta-Manohar force-pushed the master branch 2 times, most recently from 2176f15 to 33ceab7 Compare July 27, 2020 09:07
@danhermann danhermann self-requested a review July 28, 2020 12:48
danhermann
danhermann reviewed Jul 28, 2020
View reviewed changes
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raj-Datta-Manohar, thank you for this contribution. It looks pretty good and I think we'll be able to get it merged in. I left one minor comment below about line lengths.

server/src/main/java/org/elasticsearch/rest/action/cat/RestNodesAction.java Show resolved Hide resolved
@danhermann
Copy link
Contributor

@elasticmachine ok to test

@danhermann
Copy link
Contributor

@elasticmachine update branch

@danhermann
Copy link
Contributor

Thanks, @Raj-Datta-Manohar! This looks good now and I'll get it merged.

@danhermann danhermann merged commit a79d6ca into elastic:master Jul 30, 2020
@danhermann danhermann mentioned this pull request Jul 30, 2020
Merged
danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request Aug 11, 2020
@Raj-Datta-Manohar @danhermann
Adding Hit counts and Miss counts for QueryCache exposed through REST…
fe71165 
… api. (elastic#60114)
@danhermann danhermann mentioned this pull request Aug 11, 2020
Merged
danhermann added a commit that referenced this pull request Aug 12, 2020
@danhermann
Adding Hit counts and Miss counts for QueryCache exposed through REST…
538c93c 
… api. (#60114) (#60993)
@danhermann danhermann mentioned this pull request Aug 31, 2020
Merged
@Mpdreamz Mpdreamz mentioned this pull request Nov 16, 2020
Closed
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhermann danhermann Awaiting requested review from danhermann

Assignees
No one assigned
Labels
:Data Management/CAT APIs Text APIs behind /_cat >enhancement Team:Data Management Meta label for data/management team v7.10.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add query cache hit count and field data cache hit count to rest API
5 participants
@Raj-Datta-Manohar @elasticmachine @danhermann @jakelandis @romseygeek