Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename datastream to data_stream. #60658

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Aug 4, 2020

The name of the feature having a space: "data stream", the key should
have an underscore.

The name of the feature having a space: "data stream", the key should
have an underscore.
@jpountz jpountz added >enhancement :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.9.0 v7.10.0 labels Aug 4, 2020
@jpountz jpountz requested review from dakrone and ruflin August 4, 2020 15:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Aug 4, 2020
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the agents are all updating their side as well?

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jpountz
Copy link
Contributor Author

jpountz commented Aug 5, 2020

LGTM, I assume the agents are all updating their side as well?

Indeed.

@jpountz jpountz merged commit c78b432 into elastic:master Aug 5, 2020
@jpountz jpountz deleted the rename_datastream_to_data_stream branch August 5, 2020 07:32
@ruflin
Copy link
Contributor

ruflin commented Aug 5, 2020

@jpountz Will you follow up with a PR removing dataset?

@jpountz
Copy link
Contributor Author

jpountz commented Aug 5, 2020

@ruflin Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >enhancement Team:Data Management Meta label for data/management team v7.9.0 v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants