-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include authentication type for the authenticate response #61247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>enhancement
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
v8.0.0
v7.10.0
labels
Aug 18, 2020
Pinging @elastic/es-security (:Security/Authentication) |
tvernum
reviewed
Aug 21, 2020
...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/Authentication.java
Outdated
Show resolved
Hide resolved
…security/authc/Authentication.java Co-authored-by: Tim Vernum <[email protected]>
Thanks for the feedback @tvernum You are right that lowercase is the convention. I have updated the PR. |
tvernum
approved these changes
Aug 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ywangd
added a commit
that referenced
this pull request
Aug 21, 2020
61 tasks
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 23, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 26, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 26, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 26, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 30, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096 Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Nov 30, 2020
elastic/elasticsearch#61247 added a new "authentication_type" field to the response of "GET _security/_authenticate". This commit adds this as a property of the `AuthenticateResponse` type. Contributes to meta issue #5096 Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
v7.10.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new "authentication_type" field to the response of "GET _security/_authenticate".
Resolves: #61130