Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include authentication type for the authenticate response #61247

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Aug 18, 2020

Add a new "authentication_type" field to the response of "GET _security/_authenticate".

Resolves: #61130

@ywangd ywangd added >enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.10.0 labels Aug 18, 2020
@ywangd ywangd requested a review from tvernum August 18, 2020 06:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Authentication)

@elasticmachine elasticmachine added the Team:Security Meta label for security team label Aug 18, 2020
@ywangd
Copy link
Member Author

ywangd commented Aug 21, 2020

Thanks for the feedback @tvernum You are right that lowercase is the convention. I have updated the PR.

@ywangd ywangd requested a review from tvernum August 21, 2020 06:53
Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywangd ywangd merged commit eecee44 into elastic:master Aug 21, 2020
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Aug 21, 2020
)

Add a new "authentication_type" field to the response of "GET _security/_authenticate".
ywangd added a commit that referenced this pull request Aug 21, 2020
…61411)

Add a new "authentication_type" field to the response of "GET _security/_authenticate".
stevejgordon added a commit to elastic/elasticsearch-net that referenced this pull request Nov 23, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096
stevejgordon added a commit to elastic/elasticsearch-net that referenced this pull request Nov 26, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096
github-actions bot pushed a commit to elastic/elasticsearch-net that referenced this pull request Nov 26, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096
github-actions bot pushed a commit to elastic/elasticsearch-net that referenced this pull request Nov 26, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096
stevejgordon added a commit to elastic/elasticsearch-net that referenced this pull request Nov 30, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096

Co-authored-by: Steve Gordon <[email protected]>
stevejgordon added a commit to elastic/elasticsearch-net that referenced this pull request Nov 30, 2020
elastic/elasticsearch#61247 added a new
"authentication_type" field to the response of
"GET _security/_authenticate". This commit adds this as a property of
the `AuthenticateResponse` type.

Contributes to meta issue #5096

Co-authored-by: Steve Gordon <[email protected]>
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add authentication type to authentication response
4 participants