Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network from MaxMind Geo ASN database #61676

Merged
merged 6 commits into from
Sep 24, 2020

Conversation

ansell
Copy link
Contributor

@ansell ansell commented Aug 29, 2020

This adds the network property from the MaxMind Geo ASN database. This enables analysis of IP data based on the subnets that MaxMind have previously identified for ASN networks.

Signed-off-by: Peter Ansell [email protected]

@pugnascotia pugnascotia added :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement labels Aug 31, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Ingest)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Aug 31, 2020
@pugnascotia
Copy link
Contributor

@elasticmachine test this please

@ansell
Copy link
Contributor Author

ansell commented Aug 31, 2020

@pugnascotia I have pushed a change to fix the test that failed.

@pugnascotia pugnascotia requested a review from jakelandis August 31, 2020 11:36
@jakelandis
Copy link
Contributor

@elasticmachine ok to test

@jakelandis
Copy link
Contributor

@elasticmachine update branch

1 similar comment
@jakelandis
Copy link
Contributor

@elasticmachine update branch

@jakelandis
Copy link
Contributor

@ansell - changes look good. Can you add a mention of network to doc here: https://github.com/elastic/elasticsearch/blob/master/docs/reference/ingest/processors/geoip.asciidoc

@ansell
Copy link
Contributor Author

ansell commented Sep 5, 2020

@jakelandis I have added the new field name to the documented list for the ASN database.

@jakelandis
Copy link
Contributor

@elasticmachine update branch

@jakelandis
Copy link
Contributor

@elasticmachine update branch

@jakelandis jakelandis changed the title issue #60942 : Add network from MaxMind Geo ASN database Add network from MaxMind Geo ASN database Sep 24, 2020
@jakelandis jakelandis merged commit b40bdd3 into elastic:master Sep 24, 2020
jakelandis pushed a commit to jakelandis/elasticsearch that referenced this pull request Sep 24, 2020
This adds the network property from the MaxMind Geo ASN database. 
This enables analysis of IP data based on the subnets that MaxMind have 
previously identified for ASN networks.

closes elastic#60942
jakelandis added a commit that referenced this pull request Oct 1, 2020
This adds the network property from the MaxMind Geo ASN database. 
This enables analysis of IP data based on the subnets that MaxMind have 
previously identified for ASN networks.

closes #60942

Co-authored-by: Peter Ansell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v7.10.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants