Resolve minbound maxbound NullPointerException #64091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
suggested changes
Oct 26, 2020
| @@ -194,11 +194,17 @@ public HistogramAggregationBuilder offset(double offset) { | |||
|
|
|||
| /** Get the current minimum bound that is set on this builder. */ | |||
| public double minBound() { | |||
| if (extendedBounds.getMin() == null) { | |||
| return Double.NEGATIVE_INFINITY; | |||
There was a problem hiding this comment.
I think this should be other way around: POSITIVE_INFINITY for min and NEGATIVE_INFiNITY for max. Otherwise specifying null extended bounds would mean we want bounds to extend bounds to the entire range. This should be also consistent with the behaviour which was before this issues was introduced in #60556.
Please also note that extendedBounds themselves can be null, so I would suggest using DoubleBounds#getEffectiveMin instead.
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
@elasticmachine test this please |
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix |
imotov
approved these changes
Oct 29, 2020
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
elasticmachine
added
the
Team:Analytics
imotov
changed the title
imotov
pushed a commit
to imotov/elasticsearch
that referenced
this pull request
Oct 29, 2020
Resolved nullPointerException in minbound and maxbound methods. Fixes elastic#62934
imotov
added a commit
that referenced
this pull request
Oct 29, 2020
Resolved nullPointerException in minbound and maxbound methods. Fixes #62934 Co-authored-by: Alisha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the NullPointerException when min/max bounds are set to null by returning -/+
Infinity