Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Revert "Remove aggregation's postCollect phase #68942

Merged
merged 4 commits into from
Feb 12, 2021

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Feb 11, 2021

Revert "Remove aggregation's postCollect phase (#68615)

This partially reverts #64016 and and adds #67839 and adds
additional tests that would have caught issues with the changes
in #64016. It's mostly Nik's code, I am just cleaning things up
a bit.

Co-authored-by: Nik Everett [email protected]

imotov and others added 2 commits February 11, 2021 16:23
This partially reverts elastic#64016 and  and adds elastic#67839 and adds
additional tests that would have caught issues with the changes
in elastic#64016. It's mostly Nik's code, I am just cleaning things up
a bit.

Co-authored-by: Nik Everett <[email protected]>
Fat-fingered the skip statement in this one.

Relates to elastic#66876
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Feb 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@imotov imotov merged commit 1dcdda8 into elastic:7.x Feb 12, 2021
imotov added a commit to imotov/elasticsearch that referenced this pull request Feb 16, 2021
This partially reverts elastic#64016 and and adds elastic#67839 and adds
additional tests that would have caught issues with the changes
in elastic#64016. It's mostly Nik's code, I am just cleaning things up
a bit.

Co-authored-by: Nik Everett [email protected]
imotov added a commit that referenced this pull request Feb 18, 2021
This partially reverts #64016 and and adds #67839 and adds
additional tests that would have caught issues with the changes
in #64016. It's mostly Nik's code, I am just cleaning things up
a bit.

Co-authored-by: Nik Everett [email protected]
@imotov imotov deleted the issue-66876-sorting-on-nested-7.x branch March 27, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants