Improve index parameter testing for geo_point #69414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>test
|
Pinging @elastic/es-search (Team:Search) |
iverase
changed the title
jtibshirani
approved these changes
Feb 23, 2021
| DocumentMapper mapper = createDocumentMapper(fieldMapping(b -> b.field("type", "geo_point").field("index", false))); | ||
| Mapper fieldMapper = mapper.mappers().getMapper("field"); | ||
| assertThat(fieldMapper, instanceOf(GeoPointFieldMapper.class)); | ||
| boolean searchable = ((GeoPointFieldMapper)fieldMapper).fieldType().isSearchable(); |
There was a problem hiding this comment.
We could also check that parsing omits the right fields, as in KeywordFieldMapperTests#testDisableIndex().
romseygeek
approved these changes
Feb 25, 2021
iverase
added a commit
that referenced
this pull request
Mar 23, 2021
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.9 a bug was introduced where the index parameter for geo_point field mapper was ignored. this was fixed by accident in 7.11 but the bug has remained unnoticed until now. This PR adds some more test so this should not happen again.
closes #69401