-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert processor supports validation of IPv4/IPv6 addresses #69989
Convert processor supports validation of IPv4/IPv6 addresses #69989
Conversation
Pinging @elastic/es-core-features (Team:Core/Features) |
@andrewkroh and @geekpete, I would appreciate it if you and/or other interested parties could verify that this works for the use cases you described in #36145. |
@elasticmachine update branch |
Thanks @danhermann, this looks like what I expected. One question, since this writes an |
Actually, it parses the string into an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, @jbaiera! |
cc: @elastic/es-ui in case auto-complete needs to be updated to accommodate this new |
Thanks @danhermann! Opened elastic/kibana#97461 to add support in Kibana. |
Adds a new type to the convert processor that validates IPv4/IPv6 addresses. Useful for guaranteeing that a particular field value can be mapped to an Elasticsearch ip field type. This is similar to the Beats processor functionality (described here) in which "the convert processor supports a psuedo-type for IPs. It doesn't really change the data type, but it will fail the "conversion" if the value is not an IP."
E.g.:
Resolves #36145