Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] EQL: Document Unicode escape sequences #70694

Merged
merged 6 commits into from
Mar 23, 2021
Merged

[DOCS] EQL: Document Unicode escape sequences #70694

merged 6 commits into from
Mar 23, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Mar 22, 2021

@jrodewig jrodewig added >docs General docs changes v8.0.0 :Analytics/EQL EQL querying v7.13.0 labels Mar 22, 2021
@jrodewig jrodewig marked this pull request as ready for review March 22, 2021 21:10
@elasticmachine elasticmachine added Team:QL (Deprecated) Meta label for query languages team Team:Docs Meta label for docs team labels Mar 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig requested a review from matriv March 22, 2021 21:10
@jrodewig
Copy link
Contributor Author

Thanks for the corrections and links to the specs @rw-access. Much appreciated!

Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! lgtm

@@ -410,6 +410,13 @@ double quote (`"`), must be escaped with a preceding backslash (`\`).
|`\"` | Double quote (`"`)
|====

You can escape Unicode characters using a case-insensitive hexadecimal
`\u{XXXXXXXX}` escape sequence. Hexadecimal values shorter than 8 characters are
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a sentence that 2-8, or that max 8 hex digits are allowed?
values shorter than 8 chars can imply that more than 8 are allowed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback @matriv. I've noted that hex values are 2-8 chars with 9b36d89.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fast response and the PR!
Left a comment.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@jrodewig
Copy link
Contributor Author

Thanks @rw-access @matriv!

@jrodewig jrodewig merged commit 321f46e into elastic:master Mar 23, 2021
@jrodewig jrodewig deleted the docs__eql-unicode-escape-sequences branch March 23, 2021 12:10
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants