-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] EQL: Document Unicode escape sequences #70694
[DOCS] EQL: Document Unicode escape sequences #70694
Conversation
Pinging @elastic/es-ql (Team:QL) |
Pinging @elastic/es-docs (Team:Docs) |
Co-authored-by: Ross Wolf <[email protected]>
Thanks for the corrections and links to the specs @rw-access. Much appreciated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! lgtm
docs/reference/eql/syntax.asciidoc
Outdated
@@ -410,6 +410,13 @@ double quote (`"`), must be escaped with a preceding backslash (`\`). | |||
|`\"` | Double quote (`"`) | |||
|==== | |||
|
|||
You can escape Unicode characters using a case-insensitive hexadecimal | |||
`\u{XXXXXXXX}` escape sequence. Hexadecimal values shorter than 8 characters are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a sentence that 2-8, or that max 8 hex digits are allowed?
values shorter than 8 chars
can imply that more than 8 are allowed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fast response and the PR!
Left a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!!
Thanks @rw-access @matriv! |
Documents escape sequences for Unicode characters in EQL.
Relates to #70514 and #62832.
Preview
https://elasticsearch_70694.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/eql-syntax.html#eql-syntax-escape-characters