Add the cluster name to the "/" endpoint #7524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.
| super(settings, client); | ||
| this.version = version; | ||
| controller.registerHandler(GET, "/", this); | ||
| controller.registerHandler(HEAD, "/", this); | ||
| this.clusterName = clusterName; |
There was a problem hiding this comment.
Unlikely to matter, but you should put this assignment above the handler registration since it hands out a reference to an incomplete object that could cause trouble.
There was a problem hiding this comment.
Fair enough. Pushed another commit with this changed.
|
LGTM, useful tiny little piece! |
bleskes
added a commit
that referenced
this pull request
Sep 1, 2014
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list. Closes #7524
bleskes
added a commit
that referenced
this pull request
Sep 8, 2014
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list. Closes #7524
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root endpoint returns basic information about this node, like it's name and ES version etc. The cluster name is an important information that belongs in that list.