Deprecate single-tier allocation filtering settings #76516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
80 tasks
|
@elasticmachine run elasticsearch-ci/part-2 |
|
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
|
Related to #73074 |
jbaiera
requested changes
Aug 26, 2021
...gin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
Outdated
Show resolved
Hide resolved
...gin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/NodeDeprecationChecks.java
Outdated
Show resolved
Hide resolved
...in/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecks.java
Show resolved
Hide resolved
| static DeprecationIssue checkIndexRoutingRequireSetting(IndexMetadata indexMetadata) { | ||
| return checkRemovedSetting(indexMetadata.getSettings(), | ||
| INDEX_ROUTING_REQUIRE_SETTING, | ||
| "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_allocation_changes", |
There was a problem hiding this comment.
Same docs question as earlier for these as well.
|
Not sure what the best course of action here would be in regards to pointing out the new property that should be used. We could point it out as the path forward in the deprecation message, or we could state it in the docs, either would be fine. Docs might be easier since all these will be pointing to that one place. |
|
@elasticmachine update branch |
masseyke
deleted the
feature/tier-allocation-filtering-deprecation-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding deprecation info API checks for the following properties that were removed in 8.0:
cluster.routing.allocation.require._tier
cluster.routing.allocation.include._tie;
cluster.routing.allocation.exclude._tier
index.routing.allocation.require._tier
index.routing.allocation.include._tier
index.routing.allocation.exclude._tier