Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing test keytab to use aes256-cts-hmac-sha1-96 instead of des3-cbc-sha1-kd #78703

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Oct 5, 2021

The des3-cbc-sha1-kd encryption type is deprecated and no longer supported by newer jvm, causing tests
that use the krb5kdc-fixture to fail. This commit changes the encryption type of the test keytab to
aes256-cts-hmac-sha1-96.
Relates #78423

Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but I defer to @jkakavas on the FIPS comment

@masseyke
Copy link
Member Author

@jkakavas any objection to this one?

@masseyke masseyke merged commit dcd2769 into elastic:master Oct 18, 2021
@masseyke masseyke deleted the fix/update-keytab-encryption-type branch October 18, 2021 13:50
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 18, 2021
* upstream/master:
  Changing test keytab to use aes256-cts-hmac-sha1-96 instead of des3-cbc-sha1-kd (elastic#78703)
  Add support for configuring HNSW parameters (elastic#79193)
  Deprecate resolution loss on date field (elastic#78921)
  Add Optional to Configure bind user (elastic#78303)
  Adapt BWC after backporting elastic#78765 (elastic#79350)
  [DOCS] Add deprecation notice for reset password tool (elastic#78793)
  added test for flattened type in top_metrics.yml (elastic#78960)
  [DOCS] Fixes indentation issue in GET trained models API docs. (elastic#79347)
  Fix parsing of PBES2 encrypted PKCS#8 keys (elastic#78904)
  Mute testReindex (elastic#79343)
  Node level can match action (elastic#78765)
  Fix duplicate license header in source files (elastic#79236)
  AllowAll for indicesAccessControl (elastic#78498)
  Better logging and internal user handling for operator privileges (elastic#79331)

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/MappingParser.java
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Oct 26, 2021
…bc-sha1-kd (elastic#78703)

The des3-cbc-sha1-kd encryption type is deprecated and no longer supported by newer jvm, causing tests
that use the krb5kdc-fixture to fail. This commit changes the encryption type of the test keytab to
aes256-cts-hmac-sha1-96.
Relates elastic#78423
masseyke added a commit that referenced this pull request Oct 26, 2021
…bc-sha1-kd (#78703) (#79874)

The des3-cbc-sha1-kd encryption type is deprecated and no longer supported by newer jvm, causing tests
that use the krb5kdc-fixture to fail. This commit changes the encryption type of the test keytab to
aes256-cts-hmac-sha1-96.
Relates #78423 #78703
jkakavas pushed a commit to jkakavas/elasticsearch that referenced this pull request Nov 9, 2021
…bc-sha1-kd (elastic#78703)

The des3-cbc-sha1-kd encryption type is deprecated and no longer supported by newer jvm, causing tests
that use the krb5kdc-fixture to fail. This commit changes the encryption type of the test keytab to
aes256-cts-hmac-sha1-96.
Relates elastic#78423
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17,
weak encryption types are disabled by default. This caused our
Kerberos integration tests to fail with an
`sun.security.krb5.KrbException: no supported default etypes for
default_tkt_enctypes` exception.

We have since changed our default encryption type to
aes256-cts-hmac-sha1-96 in elastic#78703 and we can unmute these tests
now.
jkakavas added a commit that referenced this pull request Nov 9, 2021
…bc-sha1-kd (#78703) (#80537)

The des3-cbc-sha1-kd encryption type is deprecated and no longer supported by newer jvm, causing tests
that use the krb5kdc-fixture to fail. This commit changes the encryption type of the test keytab to
aes256-cts-hmac-sha1-96.
Relates #78423

Co-authored-by: Keith Massey <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17, weak
encryption types are disabled by default. This caused our Kerberos
integration tests to fail with an `sun.security.krb5.KrbException: no
supported default etypes for default_tkt_enctypes` exception. We have
since changed our default encryption type to aes256-cts-hmac-sha1-96 in
#78703 and we can unmute these tests now.
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17, weak
encryption types are disabled by default. This caused our Kerberos
integration tests to fail with an `sun.security.krb5.KrbException: no
supported default etypes for default_tkt_enctypes` exception. We have
since changed our default encryption type to aes256-cts-hmac-sha1-96 in
elastic#78703 and we can unmute these tests now.
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17, weak
encryption types are disabled by default. This caused our Kerberos
integration tests to fail with an `sun.security.krb5.KrbException: no
supported default etypes for default_tkt_enctypes` exception. We have
since changed our default encryption type to aes256-cts-hmac-sha1-96 in
elastic#78703 and we can unmute these tests now.
# Conflicts:
#	x-pack/qa/kerberos-tests/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosAuthenticationIT.java
elasticsearchmachine pushed a commit that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17, weak
encryption types are disabled by default. This caused our Kerberos
integration tests to fail with an `sun.security.krb5.KrbException: no
supported default etypes for default_tkt_enctypes` exception. We have
since changed our default encryption type to aes256-cts-hmac-sha1-96 in
#78703 and we can unmute these tests now.
jkakavas added a commit that referenced this pull request Nov 9, 2021
We used to default enctypes to des3-cbc-sha1-kd but with JDK17, weak
encryption types are disabled by default. This caused our Kerberos
integration tests to fail with an `sun.security.krb5.KrbException: no
supported default etypes for default_tkt_enctypes` exception. We have
since changed our default encryption type to aes256-cts-hmac-sha1-96 in
#78703 and we can unmute these tests now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants