Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal link in migration guide #79489

Merged

Conversation

DaveCTurner
Copy link
Contributor

In #79451 we introduced an internal link in the migration guide, but
this has to be an external link so that these docs can be re-used in the
stack-wide guide too. This fixes that oversight.

In elastic#79451 we introduced an internal link in the migration guide, but
this has to be an external link so that these docs can be re-used in the
stack-wide guide too. This fixes that oversight.
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v7.16.1 labels Oct 19, 2021
@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Oct 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@DaveCTurner DaveCTurner requested a review from jrodewig October 19, 2021 15:20
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one duplicate word. Otherwise LGTM.

The `408 Request timeout` response code is not appropriate for this situation
and its use is deprecated. Future versions will use the response code `200 OK`
for both cases.
The {ref}/cluster-health.html[cluster health API] API includes options for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo

Suggested change
The {ref}/cluster-health.html[cluster health API] API includes options for
The {ref}/cluster-health.html[cluster health API] includes options for

@DaveCTurner DaveCTurner merged commit 1ca828b into elastic:7.x Oct 19, 2021
@DaveCTurner DaveCTurner deleted the 2021-10-19-fix-cluster-health-link-79451 branch October 19, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants