Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test example.com, googleapis.com, and content-autofill.googleapis.com #82898

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Test example.com, googleapis.com, and content-autofill.googleapis.com #82898

merged 6 commits into from
Jan 27, 2022

Conversation

justincr-elastic
Copy link
Contributor

@justincr-elastic justincr-elastic commented Jan 20, 2022 •
edited
Loading

Add extra tests to RegisteredDomainProcessorTests.java.

See #67611 when tests were originally added.

@justincr-elastic justincr-elastic added >non-issue :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v8.1.0 labels Jan 20, 2022
@justincr-elastic justincr-elastic self-assigned this Jan 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

danhermann
danhermann approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one comment below about re-ordering one of the tests and adding a comment about their intent. If you can do that, this PR looks good to me.

...est-common/src/test/java/org/elasticsearch/ingest/common/RegisteredDomainProcessorTests.java Show resolved Hide resolved
@justincr-elastic
Copy link
Contributor Author

@elasticmachine update branch

@justincr-elastic
Copy link
Contributor Author

I don't understand why the build randomly failed twice in unrelated areas. Retrying branch update again.

@justincr-elastic
Copy link
Contributor Author

@elasticmachine update branch

@danhermann
Copy link
Contributor

LGTM 👍

@justincr-elastic
Copy link
Contributor Author

@elasticmachine update branch

@justincr-elastic justincr-elastic merged commit 1504c93 into elastic:master Jan 27, 2022
@tvernum tvernum mentioned this pull request Jun 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danhermann danhermann Awaiting requested review from danhermann

Assignees

@justincr-elastic justincr-elastic

Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >non-issue Team:Data Management Meta label for data/management team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justincr-elastic @elasticmachine @danhermann