Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Push back excessive requests for stats" (#83832) from 8.2 #85504

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

joegallo
Copy link
Contributor

Due to #85333, we want to have a little longer to figure out how to address #51992 -- for the moment, that looks like reverting #83832 from 8.2 so that we have another release cycle to figure out what changes (if any) to make to #83832 in order to address the issues raised on #85333.

Once this is merged, I'll update the version tag on #83832 to 8.3.0 rather than 8.2.0

@joegallo joegallo added >non-issue :Data Management/Stats Statistics tracking and retrieval APIs v8.2.0 labels Mar 30, 2022
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Mar 30, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is a straight revert without other changes (which it looks like it is) LGTM :)

@joegallo
Copy link
Contributor Author

Yeah, there was a trivial conflict that I resolved but besides that it's a straight revert.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is a straight revert like Armin said, this LGTM; but can you please change the title to have some keywords for what this is actually reverting (not just an issue number) as like 90% of my memory is based on title-matching things in my browser history? :D

@joegallo joegallo changed the title Revert #83832 from 8.2 Revert "Push back excessive requests for stats" (#83832) from 8.2 Mar 30, 2022
@joegallo joegallo merged commit 184ace7 into elastic:8.2 Mar 31, 2022
@joegallo joegallo deleted the revert-83832-from-8.2 branch March 31, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Stats Statistics tracking and retrieval APIs >non-issue Team:Data Management Meta label for data/management team v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants