Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't output default values in text query xcontent representations #86979

Merged
merged 1 commit into from
May 23, 2022
Merged

Don't output default values in text query xcontent representations #86979

merged 1 commit into from
May 23, 2022

Conversation

romseygeek
Copy link
Contributor

This removes default values from the xcontent representations of the
following queries:

  • intervals
  • combined_fields
  • match_bool_prefix
  • match_phrase_prefix
  • match_phrase
  • multi_match
  • query_string
  • simple_query_string

@romseygeek romseygeek added :Search/Search Search-related issues that do not fall into other categories >refactoring Team:Clients Meta label for clients team v8.3.0 labels May 20, 2022
@romseygeek romseygeek self-assigned this May 20, 2022
@elasticmachine elasticmachine added the Team:Search Meta label for search team label May 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@romseygeek romseygeek mentioned this pull request May 20, 2022
Open
@romseygeek romseygeek requested a review from javanna May 20, 2022 15:47
javanna
javanna approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @romseygeek

@romseygeek romseygeek merged commit ca542fe into elastic:master May 23, 2022
@romseygeek romseygeek deleted the queries/slimline-match-toxcontent branch May 23, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees

@romseygeek romseygeek

Labels
>refactoring :Search/Search Search-related issues that do not fall into other categories Team:Clients Meta label for clients team Team:Search Meta label for search team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romseygeek @elasticmachine @javanna