[DOCS] Adds note about escaping backslashes in regex #89276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdonpijpelink
added
>docs
|
Pinging @elastic/es-docs (Team:Docs) |
abdonpijpelink
requested review from
immavalls,
crisdarocha,
tvernum and
joegallo
immavalls
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Thanks, @abdonpijpelink, for the fast response. It looks good to me, @crisdarocha might have more feedback as he's been involved in the investigation that led to this
crisdarocha
approved these changes
Aug 11, 2022
joegallo
reviewed
Aug 11, 2022
debadair
approved these changes
Aug 16, 2022
abdonpijpelink
added a commit
to abdonpijpelink/elasticsearch
that referenced
this pull request
Aug 17, 2022
* [DOCS] Adds note about escaping backslashes in regex * Fix typo * Simplify example
abdonpijpelink
added a commit
to abdonpijpelink/elasticsearch
that referenced
this pull request
Aug 17, 2022
* [DOCS] Adds note about escaping backslashes in regex * Fix typo * Simplify example
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 17, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backslash character is an escape character in both JSON strings and regular expressions. This PR adds a note with an example about the need to escape both.
You can preview the change here: https://elasticsearch_89276.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/regexp-syntax.html#regexp-reserved-characters