simplify ./gradlew run-ccs #89711
Merged
simplify ./gradlew run-ccs #89711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview: |
Closed
jakelandis
commented
Aug 29, 2022
| @@ -37,8 +37,8 @@ default void useCluster(Provider<ElasticsearchCluster> cluster) { | |||
|
|
|||
| default void beforeStart() {} | |||
|
|
|||
| default void enableDebug(int portOffset) { | |||
| int debugPort = 5007 + portOffset; | |||
| default void enableDebug() { | |||
There was a problem hiding this comment.
part of the revert
jakelandis
commented
Aug 29, 2022
| @@ -104,7 +104,7 @@ public WorkResult delete(Object... objects) { | |||
| @Override | |||
| public void beforeStart() { | |||
| if (debugServer) { | |||
| enableDebug(0); | |||
| enableDebug(); | |||
There was a problem hiding this comment.
part of the revert
jakelandis
commented
Aug 29, 2022
| @@ -35,16 +35,12 @@ public class RunTask extends DefaultTestClustersTask { | |||
|
|
|||
| private Boolean debug = false; | |||
|
|
|||
There was a problem hiding this comment.
all changes are part of the revert
jakelandis
commented
Aug 29, 2022
| node.setting('cluster.remote.my_remote_cluster.seeds', fulfillingCluster.get().getAllTransportPortURI().collect { "\"$it\"" }.toString()) | ||
| } | ||
| } | ||
| queryingCluster.get().restart() //updates the on-disk config |
There was a problem hiding this comment.
this is the main change. specifically calling .restart() to update the configuration on disk
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
thanks Mark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the changes introduced via #89442 / 20ed7e3
and re-implements the same goals but with fewer changes. Also included in this commit
is the ability to change the proxyMode via system property and mention of this
new run task in the testing documentation.
===
While working #89563 I found a better pattern that does not require updates to the run task. I think this approach is cleaner especially for debugging.