Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Enable bwc and fix sorting for 500_date_range #90681

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[Testing] Enable bwc and fix sorting for 500_date_range #90681

merged 2 commits into from
Oct 5, 2022

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Oct 5, 2022

the #90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes #90668

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Testing] Enable bwc and fix sorting for 500_date_range
bb16c05 
the elastic#90458 has been backported to all branches so the bwc testing can be enable for this
tests were incorrectly relying on sort order. Added sort to make it deterministic

closes elastic#90668
@pgomulka pgomulka added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v6.8.6 auto-backport Automatically create backport pull requests when merged v8.5.0 v7.17.7 labels Oct 5, 2022
@pgomulka pgomulka self-assigned this Oct 5, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Oct 5, 2022
@pgomulka
Copy link
Contributor Author

pgomulka commented Oct 5, 2022

ok to test

@pgomulka pgomulka merged commit 3eaaffb into elastic:main Oct 5, 2022
@pgomulka pgomulka mentioned this pull request Oct 5, 2022
Closed
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 5, 2022
@pgomulka
[Testing] Enable bwc and fix sorting for 500_date_range (elastic#90681)
e99172d 
the elastic#90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes elastic#90668
This was referenced Oct 5, 2022
Merged
Merged
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 5, 2022
@pgomulka
[Testing] Enable bwc and fix sorting for 500_date_range (elastic#90681)
bfb726f 
the elastic#90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes elastic#90668
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.17
✅ 8.5

pgomulka added a commit that referenced this pull request Oct 6, 2022
@pgomulka
[8.5][Testing] Enable bwc and fix sorting for 500_date_range backport(#…
7cc25c0 
…90681) (#90690)

the #90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes #90668
pgomulka added a commit that referenced this pull request Oct 6, 2022
@pgomulka
[7.17] [Testing] Enable bwc and fix sorting for 500_date_range (#90681)…
994c3c6 
… (#90689)

the #90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes #90668
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Oct 10, 2022
@weizijun
Merge branch 'main' into aggregate_metric_double-add-max-min-valid
35bac3e 
* main: (150 commits)
  Remove ToXContent interface from ChunkedToXContent (elastic#90409)
  Remove extra SearchService constructor (elastic#90733)
  Update min version for the diagnosis yaml test (elastic#90731)
  Use the AggTestConfig object in testCase (elastic#90699)
  [DOCS] Add links to clear trained model deployment cache API (elastic#90727)
  Assert wildcards are not expanded as specified by request options  (elastic#90641)
  [TEST] Fix exit snapshot restore exit condition (elastic#90696)
  [TEST] Change to atomic file contents save (elastic#90695)
  Update forbiddenapis to 3.4 (elastic#90624)
  [Tests] Don't use concurrent search in scripted field type tests (elastic#90712)
  [ML] Move scaling is possible check for starting trained model (elastic#90706)
  Add new base test case for chunked xcontent types  (elastic#90707)
  Fix testRedNoBlockedIndicesAndRedAllRoleNodes (elastic#90671)
  Fix nullpointer in docs test setup (elastic#90660)
  Don't produce build logs artifact when in a composite build
  Fixing a race condition in EnrichCoordinatorProxyAction that can leave an item stuck in its queue (elastic#90688)
  docs: update fleet/agent pipeline docs (elastic#90659)
  [HealthAPI] Use plural consistently in resource types (elastic#90682)
  [Testing] Enable bwc and fix sorting for 500_date_range (elastic#90681)
  Add profiling and documentation for dfs phase (elastic#90536)
  ...

# Conflicts:
#	x-pack/plugin/mapper-aggregate-metric/src/test/java/org/elasticsearch/xpack/aggregatemetric/mapper/AggregateDoubleMetricFieldMapperTests.java
@javanna javanna mentioned this pull request Oct 11, 2022
Closed
@cbuescher cbuescher mentioned this pull request Oct 31, 2022
Closed
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Oct 31, 2022
@pgomulka
[8.4][Testing] Fix sorting for 500_date_range backport(elastic#90681) (…
4cb854c 
…elastic#90690)

the elastic#90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

closes elastic#90668
pgomulka added a commit that referenced this pull request Oct 31, 2022
@pgomulka
[8.4][Testing] Fix sorting for 500_date_range backport(#90681) (#90690)…
d99f8df 
… (#91201)

the #90458 has been backported to all branches so the bwc testing can be enable for this tests were incorrectly relying on sort order. Added sort to make it deterministic

close #90783
@csoulios csoulios added v8.5.0 and removed v8.5.1 labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.17.7 v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
3 participants
@pgomulka @elasticsearchmachine @csoulios