Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs+] Add support for logs@custom component template #95481

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

eyalkoren
Copy link
Contributor

Closes #95469

@eyalkoren eyalkoren added >enhancement :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.8.0 labels Apr 23, 2023
@eyalkoren eyalkoren requested a review from felixbarny April 23, 2023 13:48
@eyalkoren eyalkoren self-assigned this Apr 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Apr 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @eyalkoren, I've created a changelog YAML for you.

Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by accident

@felixbarny felixbarny requested a review from joshdover April 23, 2023 15:06
Copy link
Member

@felixbarny felixbarny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of having dedicated release notes it's probably worth splitting the PR into two parts.

@eyalkoren eyalkoren removed the v8.8.0 label Apr 25, 2023
@eyalkoren
Copy link
Contributor Author

This issue is currently blocked on #95527

@felixbarny
Copy link
Member

Hey @joshdover the reason I asked for a PR review on this was to make sure we align with the Fleet naming conventions for the custom component template and to make sure this aligns with your visions for this issue:

Once we've added the logs@custom component template to the logs-*-* index template, we should probably do the same for Fleet-managed logs data streams as well. WDYT?

cc @kpollich

@eyalkoren eyalkoren requested a review from dakrone April 27, 2023 11:41
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruflin
Copy link
Contributor

ruflin commented Apr 27, 2023

We should follow up with documentation around how this "feature" should be used. Not sure where the best place is in Elasticsearch docs for this.

@felixbarny felixbarny merged commit af8725f into elastic:main Apr 27, 2023
@eyalkoren eyalkoren deleted the custom-logs-mapping-template branch April 30, 2023 06:32
@eyalkoren
Copy link
Contributor Author

@dakrone shouldn't have we increment the stack template registry version with this change, as well as the changes made through #95329?

@dakrone
Copy link
Member

dakrone commented May 1, 2023

@dakrone shouldn't have we increment the stack template registry version with this change, as well as the changes made through #95329?

@eyalkoren yes, we should increment it once (per release, it's not necessary to increment it for each change) for all the changes that are being made to the template(s).

@eyalkoren
Copy link
Contributor Author

OK, I will.
Out of curiosity, what is the reason for not using something less manual, for example- relying on the release <major>.<minor> version for these upgrade decisions? Is it because of overhead related to unnecessary upgrades?

eyalkoren added a commit that referenced this pull request May 2, 2023
Required due to changes made in stack templates in #95481 and #95329
@dakrone
Copy link
Member

dakrone commented May 2, 2023

Out of curiosity, what is the reason for not using something less manual, for example- relying on the release . version for these upgrade decisions? Is it because of overhead related to unnecessary upgrades?

Yeah, we'd like to not have to reinstall the templates if there have been no changes between rolling versions. Additionally, there have been occasions where we want to make changes in the "make this change if the template doesn't already exist, or gets deleted, but don't make it if it already exists" vein.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Data streams Data streams and their lifecycles >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a logs@custom component template for users to customize settings
5 participants