-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs+] Add support for logs@custom
component template
#95481
[Logs+] Add support for logs@custom
component template
#95481
Conversation
Pinging @elastic/es-data-management (Team:Data Management) |
Hi @eyalkoren, I've created a changelog YAML for you. |
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved by accident
… into custom-logs-mapping-template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of having dedicated release notes it's probably worth splitting the PR into two parts.
This issue is currently blocked on #95527 |
Hey @joshdover the reason I asked for a PR review on this was to make sure we align with the Fleet naming conventions for the custom component template and to make sure this aligns with your visions for this issue: Once we've added the cc @kpollich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should follow up with documentation around how this "feature" should be used. Not sure where the best place is in Elasticsearch docs for this. |
@dakrone shouldn't have we increment the stack template registry version with this change, as well as the changes made through #95329? |
@eyalkoren yes, we should increment it once (per release, it's not necessary to increment it for each change) for all the changes that are being made to the template(s). |
OK, I will. |
Yeah, we'd like to not have to reinstall the templates if there have been no changes between rolling versions. Additionally, there have been occasions where we want to make changes in the "make this change if the template doesn't already exist, or gets deleted, but don't make it if it already exists" vein. |
Closes #95469