Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiComboBox #498

Closed
cjcenizal opened this issue Mar 12, 2018 · 1 comment
Closed

EuiComboBox #498

cjcenizal opened this issue Mar 12, 2018 · 1 comment

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 12, 2018

Prototype: #52

Taken from elastic/kibana#12543:

Extracted from elastic/kibana#12325.

We need to implement ARIA accessibility for this component:

  • Alt + Down: If the input has focus, open the dropdown.
  • Alt + Up: Close the dropdown and focus the input.
  • Up/Down: Move focus to the previous/next option.
  • Page Up/Down: Move focus to the previous/next page's option.
  • Escape: Close the dropdown and focus the input.
  • Enter: If an option is focused, select it, close the dropdown, and focus the input.
  • (Any character): If an option is focused, move focus to the option that begins with that character.

References to the draft spec:

References to similar components:


Per comment by @chrisronline:

One accessibility problem we need to avoid is ensuring that, assuming multiple selections are enabled, the user can reselect previously selected items and remove them and be notified of which are removed. With ui-select, they can just backspace to remove them but they can't choose which ones to remove or aren't even told which ones were removed. Maybe have the tab button go through the selected options before exiting out of the control?

@snide
Copy link
Contributor

snide commented Mar 30, 2018

Closing this now that it's in. We have follow up issues for additional feature work on this component.

@snide snide closed this as completed Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants