Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Surface information about indices and index patterns when creating a new index pattern. #12325

Closed

Conversation

cjcenizal
Copy link
Contributor

Addresses #10438 and #5053

Here's the flow I'm going to shoot for:

image

Replaces #11748

@snide
Copy link
Contributor

snide commented Jun 22, 2017

Pretty close. Glad you're thinking about making one of these. Couple notes.

  1. You don't need the language on most of these. Most of this stuff is normal patterns people are used to. If you want to illustrate that it's a partial match it's better to highlight part of the word logstash.
  2. Likely want a placeholder or help text to let them know they can use *
    • When * is used nothing should be selectable. You'll want to visually separate the matches from selections somehow. The only selectable item is the "will match against all...".
  3. Since they can't just hit enter on "log" when it's a partial match, you should always have something in the select state (default would be the first item matched). Essentially this means your second pane can be dropped, it'll always be the third pane in some form.
  4. Looking at the way they've been doing this with the watcher PR, you'll need an empty state (no results) and a loading state. Usual place for the loader is to replace the caret icon with a small spinner while it "loads".
  5. Can people select more than one? If so you'll need pills.
  6. Search is going to be a ton more specific than tabs. Simply putting the (type) next to the result in a mixed list is enough and will be much faster for the user.

You might want to check out some of the patterns established in K7 for this kind of stuff. It has exception examples for what to do when things get too long...etc.

image

@cjcenizal cjcenizal force-pushed the 10438/index-pattern-typeahead branch 4 times, most recently from a0f38a8 to e15881b Compare June 27, 2017 19:11
…Creation form.

- Handle 'no matching indices' 404 error gracefully in get_indices.js.
…ionality by switching from onMouseDown back to onClick because we're using KuiKeyboardAccessible instead of a button.
@cjcenizal
Copy link
Contributor Author

Closing in favor of #12530

@cjcenizal cjcenizal closed this Jun 28, 2017
@cjcenizal cjcenizal deleted the 10438/index-pattern-typeahead branch June 28, 2017 17:38
@cjcenizal cjcenizal mentioned this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants