-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Surface information about indices and index patterns when creating a new index pattern. #12325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
10438/index-pattern-typeahead
branch
3 times, most recently
from
June 22, 2017 02:29
3e967c6
to
0d4b30d
Compare
Pretty close. Glad you're thinking about making one of these. Couple notes.
You might want to check out some of the patterns established in K7 for this kind of stuff. It has exception examples for what to do when things get too long...etc. |
cjcenizal
force-pushed
the
10438/index-pattern-typeahead
branch
4 times, most recently
from
June 27, 2017 19:11
a0f38a8
to
e15881b
Compare
…Creation form. - Handle 'no matching indices' 404 error gracefully in get_indices.js.
…ionality by switching from onMouseDown back to onClick because we're using KuiKeyboardAccessible instead of a button.
cjcenizal
force-pushed
the
10438/index-pattern-typeahead
branch
from
June 27, 2017 22:57
e15881b
to
a3e8ae6
Compare
Closing in favor of #12530 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10438 and #5053
Here's the flow I'm going to shoot for:
Replaces #11748