-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more css text utilities #1092
Conversation
- Moved properties from `.eui-textTruncate` into a mixin and including that mixin in the utility class - Added `.eui-textBreakNormal` in case consumers need to override a applied `word-break: break-all` - Using the above class on props doc table contents to fix elastic#678
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'll defer to @snide to approve :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this one. Was so annoying.
CHANGELOG.md
Outdated
@@ -6,6 +6,7 @@ | |||
- Added `repositionOnScroll` prop to `EuiPopover` which enables repositioning the popover when the window is scrolled. ([#1064](https://github.com/elastic/eui/pull/1064)) | |||
- Allow `_` and `*` characters to be used in `EuiSearchBar` query terms ([#1058](https://github.com/elastic/eui/pull/1058)) | |||
- Added more `status` options for `EuiSteps` ([#1088](https://github.com/elastic/eui/pull/1088)) | |||
- Added more `.eui-textBreakNormal` and `@mixin euiTextTruncate` as CSS/SASS utilities ([#1092](https://github.com/elastic/eui/pull/1092)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/pasta "more".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hehe
.eui-textTruncate
into a mixin and including that mixin in the utility class.eui-textBreakNormal
in case consumers need to override a appliedword-break: break-all