Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split EuiUpdateButton from EuiSuperDatePicker so it can be used on its own #1470

Merged
merged 8 commits into from
Jan 24, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 24, 2019

Expose EuiUpdateButton as its own components so that it can be used when setting showUpdateButton to false.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in changelog, otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@nreese
Copy link
Contributor Author

nreese commented Jan 24, 2019

@cchaos Do you have any more feedback on this or can I merge?

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh Sorry, @nreese I swear I hit "comment" on this but my feedback is this

@cchaos
Copy link
Contributor

cchaos commented Jan 24, 2019

PR4U: nreese#5

* Refactor button’s prop names

* Fixing widths
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -3,6 +3,7 @@
- Added a new app icon for Code ([#1467](https://github.com/elastic/eui/pull/1467))
No public interface changes since `6.6.0`.
- Re-added EuiI18n, EuiI18nNumber, and EuiContext for localization ([#1466](https://github.com/elastic/eui/pull/1466))
- Expose `EuiSuperUpdateButton` component from `EuiSuperDatePicker` ([#1470](https://github.com/elastic/eui/pull/1470))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Expose `EuiSuperUpdateButton` component from `EuiSuperDatePicker` ([#1470](https://github.com/elastic/eui/pull/1470))
- Exposed `EuiSuperUpdateButton` component from `EuiSuperDatePicker` ([#1470](https://github.com/elastic/eui/pull/1470))

@nreese nreese merged commit 6b751f4 into elastic:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants