Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position EuiProgress over EuiHeader #1471

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

ryankeairns
Copy link
Contributor

@ryankeairns ryankeairns commented Jan 24, 2019

Summary

In cases where EuiProgress is nested within a parent whose z-index value is lower than EuiHeader (e.g. from a Kibana plugin), the header will overlay the progress bar preventing it from being seen.

To overcome this situation, a user will need to use an EuiPortal while the EuiProgress needs a z-index greater than the default for EuiHeader. This PR adds a z-index to EuiProgress and provides an example use case in the docs.

Checklist

  • This was checked in mobile
  • This was checked in IE11
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios
  • This required updates to Framer X components

@ryankeairns ryankeairns requested a review from snide January 24, 2019 17:48
@ryankeairns ryankeairns force-pushed the rk/fixed-progress-header branch from 31b72a2 to be36755 Compare January 24, 2019 17:55
@ryankeairns ryankeairns force-pushed the rk/fixed-progress-header branch from be36755 to 2ea28a3 Compare January 24, 2019 17:56
@ryankeairns
Copy link
Contributor Author

I opted to add to the existing fixed example as opposed to adding a new section since a) they feel related and 2) the latter resulted in some collisions with showing/hiding the fixed top progress bar.

In other words, those two examples aren't aware of one another and just ran over each other atop the page. Having them in the same example file made it much simpler to toggle one off when the other comes on.

@ryankeairns
Copy link
Contributor Author

One other note, I attempted to push down the content when the header example is shown, but my simple solution (using javascript to set style) didn't work on mobile when the side nav is no longer fixed. It's something we could consider improving about this example, whether now or later.

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally

@ryankeairns ryankeairns merged commit 69fe533 into elastic:master Jan 24, 2019
@snide
Copy link
Contributor

snide commented Jan 24, 2019

cc @sqren so he's aware. Will be in Kibana shortly.

@sorenlouv
Copy link
Member

Yay! Thanks for the quick reaction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants