Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@bmcconaghy noticed some issues with console and tracked to down to a Kibana upgrade of EUI from 6.3.1 to 6.5.1. I picked up the trail and tracked it down to these lines
https://github.com/elastic/eui/blob/master/src/global_styling/mixins/_typography.scss#L12
https://github.com/elastic/eui/blob/master/src/global_styling/variables/_typography.scss#L30
I don't think this is a problem with the code in EUI but a weird bug in ACE and the way they calculate cursor position based off character widths. Unfortunately we use ACE everywhere in Kibana and I'd rather cut this off here than add a lot of overwrites into our ACE implementation there. I'll be honest and say I don't know enough about this property to understand much of what it does other than effect kerning. I couldn't notice any difference in the render, but I have old eyes 😄
Checklist