EuiNavDrawerGroup default icon #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
chandlerprall
suggested changes
Mar 13, 2019
chandlerprall
approved these changes
Mar 13, 2019
snide
approved these changes
Mar 13, 2019
|
jenkins test this |
|
Tested in Kibana: beforeafter |
7 tasks
Shigawire
pushed a commit
to Shigawire/eui
that referenced
this pull request
May 10, 2019
* Pulled the initials calculation out from EuiAvatar to a string service * Added a line-height fix for images * Added a custom icon to nav drawer items that don’t provide one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1724
Instead of forcing a consumer to pass an icon, if they don't provide one, one will be created a la Avatar style and use the name to provide initials to display in collapsed view.
In order to do so, I also pulled the initials calculation out from EuiAvatar to a string service. This could probably be generalized further ( still kind of Avatar specific ) but in the interest of time, it all still works.
Checklist
[ ] Any props added have proper autodocs[ ] This was checked for breaking changes and labeled appropriately[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components