Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EuiToolTip text reflow on content changes #1744

Merged
merged 4 commits into from
Mar 20, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Mar 19, 2019

Summary

Fixes #1734, in which content changes near the right edge of the window caused longer text to wrap lines and result in incorrect, uncorrected positioning calculations.

  • Uses EuiResizeObserver instead of EuiMutationObserver. The latter did not account for side effect updates and missed possible resize changes. (This is a more forward-looking change, getting at what I think we actually want to observe).
  • Calculates EuiToolTip x-axis position from the right if nearing the right edge of the window. This prevents text wrap/reflow, negating positioning correction.

Checklist

- [ ] This was checked in mobile

  • This was checked in IE11

- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately

- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

@thompsongl thompsongl changed the title Fix tooltip reflow on content changes Fix EuiToolTip text reflow on content changes Mar 19, 2019
@thompsongl
Copy link
Contributor Author

For testing you can load up TSVB in Kibana as mentioned in the issue. Otherwise I had success simulating in EUI docs by manually positioning a button.

Gif of Proof (in Kibana):
Kapture 2019-03-19 at 15 03 34

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; pulled and tested the case with some modified doc examples

@thompsongl thompsongl merged commit 642e247 into elastic:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants