Fix EuiToolTip text reflow on content changes #1744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1734, in which content changes near the right edge of the window caused longer text to wrap lines and result in incorrect, uncorrected positioning calculations.
EuiResizeObserver
instead ofEuiMutationObserver
. The latter did not account for side effect updates and missed possible resize changes. (This is a more forward-looking change, getting at what I think we actually want to observe).EuiToolTip
x-axis position from the right if nearing the right edge of the window. This prevents text wrap/reflow, negating positioning correction.Checklist
- [ ] This was checked in mobile- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components