Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pagination prop descriptions for EuiInMemoryTable #3142

Merged
merged 10 commits into from
Mar 30, 2020
Merged

Updated pagination prop descriptions for EuiInMemoryTable #3142

merged 10 commits into from
Mar 30, 2020

Conversation

walnutdust
Copy link
Contributor

Summary

As per the discussion in #435 ,

  • Added proper documentation for EuiInMemoryTable's pagination prop
  • Fixed "Adding pagination to a BasicTable" docs section toggle being set up backwards

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Mar 21, 2020 •
edited
Loading

💚 CLA has been signed

@walnutdust
Copy link
Contributor Author

cla/check

@cchaos
Copy link
Contributor

cchaos commented Mar 24, 2020

Jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3142/

cchaos
cchaos suggested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @walnutdust. Just a couple minor things

src-docs/src/views/tables/paginated/paginated.js Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/views/tables/in_memory/props_info.js Show resolved Hide resolved
@cchaos
Copy link
Contributor

cchaos commented Mar 25, 2020

jenkins test this

cchaos
cchaos approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing those up for me. 👍

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3142/

cchaos
cchaos reviewed Mar 25, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@cchaos cchaos changed the title Docs/table pagination Updated pagination prop descriptions for EuiInMemoryTable Mar 25, 2020
@cchaos cchaos requested a review from chandlerprall March 25, 2020 23:01
@cchaos cchaos merged commit db1eb71 into elastic:master Mar 30, 2020
@chandlerprall chandlerprall mentioned this pull request Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walnutdust @kibanamachine @cchaos @chandlerprall