-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in EuiBasicTable
to handle dynamic icon value properly in collapsed actions
#3145
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@crux153 Can you please give more explanation in the summary? |
@cchaos I updated the summary. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for digging into this and finding the root cause. I've asked for two small changes, otherwise this looks great.
@chandlerprall I just copied the implementation detail from existing DefaultItemAction component. I love your setup as it is much cleaner than before, so I applied the same changes to both components. Thank you :) |
jenkins test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3145/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking down the root cause, and the extra cleanup on this one!
Summary
Fix for #3144
While
DefaultItemAction
accepts a function to dynamically change icon value as like below,It crashes when shown in
CollapsedItemActions
component, since the logic to handle functional icon prop is present only inDefaultItemAction
and missing inCollapsedItemActions
.If I pass an action with dynamic icon value like above, the table crashes when clicking the expand button in action column.
This PR adds the missing handler to
CollapsedItemActions
so that it works in the same way asDefaultItemAction
does.Checklist