-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to EuiSearchBar
etc types
#3147
Conversation
@bevacqua I think this PR address most of the points you raised in #3138. The only one left is the @chandlerprall we could address this by moving |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could address this by moving autoClose into the FieldValueSelectionFilterConfigType type - what do you think? It would mean fiddling about default props and such.
I don't see how autoClose
could ever have been used in its current form. We don't export FieldValueSelectionFilter in a consumable way, so I believe autoClose
can be moved to the config object with no problems.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Thanks @pugnascotia
Thanks folks! |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
Closes #3138.
FilterConfig
toSearchFilterConfig
and export it viaEuiSearchBar
.FieldValueOptionType
viaEuiSearchBar
.EuiSearchBoxProps
to extendEuiFieldSearchProps
, so that it includes all the HTML properties such asdisabled
. Also rework the related component code to forward on more props via...rest
.